linux-kernel - Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 04 Jan 2008 16:52:48 -0500
From:	Mark Lord <lkml@....ca>
To:	Venki Pallipadi <venkatesh.pallipadi@...el.com>
Cc:	Arjan van de Ven <arjan@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>, abelay@...ell.com,
	lenb@...nel.org, Ingo Molnar <mingo@...e.hu>,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
	rjw@...k.pl
Subject: Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

Mark Lord wrote:
> Venki Pallipadi wrote:
>> Reintroduce run time configurable max_cstate for !CPU_IDLE case.
>>
>> Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>
>>
>> Index: linux-2.6.24-rc/drivers/acpi/processor_idle.c
>> ===================================================================
>> --- linux-2.6.24-rc.orig/drivers/acpi/processor_idle.c
>> +++ linux-2.6.24-rc/drivers/acpi/processor_idle.c
>> @@ -76,7 +76,11 @@ static void (*pm_idle_save) (void) __rea
>>  #define PM_TIMER_TICKS_TO_US(p)        (((p) * 
>> 1000)/(PM_TIMER_FREQUENCY/1000))
>>  
>>  static unsigned int max_cstate __read_mostly = ACPI_PROCESSOR_MAX_POWER;
>> +#ifdef CONFIG_CPU_IDLE
>>  module_param(max_cstate, uint, 0000);
>> +#else
>> +module_param(max_cstate, uint, 0644);
>> +#endif
>>  static unsigned int nocst __read_mostly;
>>  module_param(nocst, uint, 0000);
>>  
> ..
> 
> I'll try and re-test with this on Friday.
..

Okay, with !CONFIG_CPU_IDLE, this works fine -- same as 2.6.23 and earlier.

> Meanwhile, can you give a short summary of how behaviour differs
> between CONFIG_CPU_IDLE and !CONFIG_CPU_IDLE  ??
> 
> I'm not at all clear on how this really affects things.

???
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/