| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 5 Jan 2008 21:25:59 +0100 From: Miguel Botón <mboton.lkml@...il.com> To: Ingo Molnar <mingo@...e.hu> Cc: Miguel Botón <mboton.lkml@...il.com>, linux-kernel@...r.kernel.org, tglx@...utronix.de Subject: Re: [PATCH] x86: little fix in 'include/asm-x86/topology.h' On Saturday 05 January 2008 16:09:44 Ingo Molnar wrote: > * Miguel Botón <mboton.lkml@...il.com> wrote: > > Before 'topology_32.h' and 'topology_64.h' were unified, topology > > defines in a X86_64 kernel were declared if CONFIG_SMP was enabled. > > Now, post unification, these same defines in a X86_64 kernel are only > > being declared if CONFIG_NUMA and CONFIG_SMP are enabled. > > > > This, for example, breaks 'perfmon_amd64.c' compilation. > > > > This patch defines ENABLE_TOPO_DEFINE if this is a X86_64 kernel and > > we have SMP support enabled. > > hm, do you have a .config that fails to build? > > Ingo I had a .config (I deleted it) that fails to build *but* using the tree from http://git.kernel.org/?p=linux/kernel/git/eranian/linux-2.6.git;a=summary The problem was that CONFIG_NUMA wasn't defined so ENABLE_TOPO_DEFINE wasn't defined too and then we get an error about an implicit declaration of 'topology_physical_package_id'. -- Miguel Botón -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists