linux-kernel - Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080105041228.GP3351@webber.adilger.int>
Date:	Fri, 4 Jan 2008 21:12:28 -0700
From:	Andreas Dilger <adilger@....com>
To:	Richard Knutsson <ricknu-0@...dent.ltu.se>
Cc:	Mathieu Segaud <mathieu.segaud@...ala.cx>,
	akpm@...ux-foundation.org, linux-ext4@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c

On Jan 04, 2008  14:41 +0100, Richard Knutsson wrote:
>>  @@ -54,6 +54,6 @@ int __ext4_journal_dirty_metadata(const char *where,
>>  {
>>  	int err = jbd2_journal_dirty_metadata(handle, bh);
>>  	if (err)
>> -		ext4_journal_abort_handle(where, __FUNCTION__, bh, handle,err);
>> +		ext4_journal_abort_handle(where, __FUNCTION__, bh, handle, err);
>>  	return err;
>>  }
>
> What about changing the __FUNCTION__ to __func__, while you are at it?

What's wrong with __FUNCTION__?  I thought that was ANSI C?

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/