linux-kernel - Re: [PATCH 0/7] convert semaphore to mutex in struct class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <478120D9.5090404@s5r6.in-berlin.de>
Date:	Sun, 06 Jan 2008 19:41:29 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Dave Young <hidave.darkstar@...il.com>
CC:	gregkh@...e.de, stern@...land.harvard.edu, peterz@...radead.org,
	david-b@...bell.net, davem@...emloft.net, jarkao2@...il.com,
	krh@...hat.com, dbrownell@...rs.sourceforge.net,
	James.Bottomley@...senPartnership.com, a.zummo@...ertech.it,
	cbou@...l.ru, dwmw2@...radead.org, khali@...ux-fr.org,
	i2c@...sensors.org, linux1394-devel@...ts.sourceforge.net,
	spi-devel-general@...ts.sourceforge.net,
	linux-scsi@...r.kernel.org, rtc-linux@...glegroups.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/7] convert semaphore to mutex in struct class

Dave Young wrote:
> Convert semaphore to mutex in struct class.
> All the patches in this series should be applyed simultaneously

Therefore you eventually need to repost it as a single patch.  It can't
go into one of the maintainer trees otherwise, because they only take
fully bijectable patches.  (Kernel must build and run at any point in
between any patch series.)

> toc:
> ---
> 1-driver-core-struct-class-convert-semaphore-to-mutex.patch
> 2-i2c-struct-class-convert-semaphore-to-mutex.patch
> 3-ieee1394-struct-class-convert-semaphore-to-mutex.patch
> 4-power-struct-class-convert-semaphore-to-mutex.patch
> 5-rtc-struct-class-convert-semaphore-to-mutex.patch
> 6-scsi-struct-class-convert-semaphore-to-mutex.patch
> 7-spi-struct-class-convert-semaphore-to-mutex.patch

I was going to test it at runtime on top of 2.6.24-rc6, but the first
and second patch depend on stuff in -mm.  So, my laziness wins for now,
as -mm is not my cup of tea.

About your changelog:

	"xyz: convert semaphore to mutex in struct class

	Use mutex instead of semaphore in struct class.

	Signed-off-by: Dave Young <hidave.darkstar@...il.com>"

You don't need the second line because it says the same as the first
line.  Either kill it, or replace it by an explanation _why_ the
semaphore is to be replaced by mutex.  (I guess you do it because they
are lighter-weight, both in semantics and in implementation, and because
there are better facilities to debug mutexes...)
-- 
Stefan Richter
-=====-==--- ---= --==-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/