linux-kernel - Re: [PATCH 0/7] convert semaphore to mutex in struct class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080107154404.GA10880@suse.de>
Date:	Mon, 7 Jan 2008 07:44:04 -0800
From:	Greg KH <gregkh@...e.de>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	David Brownell <david-b@...bell.net>,
	Dave Young <hidave.darkstar@...il.com>,
	stern@...land.harvard.edu, peterz@...radead.org,
	davem@...emloft.net, jarkao2@...il.com, krh@...hat.com,
	dbrownell@...rs.sourceforge.net,
	James.Bottomley@...senpartnership.com, a.zummo@...ertech.it,
	cbou@...l.ru, dwmw2@...radead.org,
	linux1394-devel@...ts.sourceforge.net,
	spi-devel-general@...ts.sourceforge.net,
	linux-scsi@...r.kernel.org, rtc-linux@...glegroups.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/7] convert semaphore to mutex in struct class

On Mon, Jan 07, 2008 at 02:23:33PM +0100, Stefan Richter wrote:
> David Brownell wrote:
> > On Monday 07 January 2008, Greg KH wrote:
> >> Most of the non-driver core code should be converted to not use the
> >> lock in the class at all.  They should use a local lock instead.
> > 
> > Or better yet, that yet-to-be-written class_for_each_instance()
> > iterator ... :)
> 
> By far most of the usages of class.semaphore or class.mutex in drivers
> are to protect the class.devices list.  The only? right thing to do
> there is to keep using the class.{semaphore,mutex}.  The more elegant
> variation of this would be David's class_for_each_instance() iterator
> which would allow us to hide the locking details from the drivers.

If such functionality is needed, fine, I have no objection to that
change to move the locking logic into the driver core.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/