linux-kernel - Re: [PATCH 0/7] convert semaphore to mutex in struct class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47825510.7050306@s5r6.in-berlin.de>
Date:	Mon, 07 Jan 2008 17:36:32 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Jarek Poplawski <jarkao2@...il.com>
CC:	David Brownell <david-b@...bell.net>, Greg KH <gregkh@...e.de>,
	Dave Young <hidave.darkstar@...il.com>,
	stern@...land.harvard.edu, peterz@...radead.org,
	davem@...emloft.net, krh@...hat.com,
	dbrownell@...rs.sourceforge.net,
	James.Bottomley@...senpartnership.com, a.zummo@...ertech.it,
	cbou@...l.ru, dwmw2@...radead.org,
	linux1394-devel@...ts.sourceforge.net,
	spi-devel-general@...ts.sourceforge.net,
	linux-scsi@...r.kernel.org, rtc-linux@...glegroups.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/7] convert semaphore to mutex in struct class

Jarek Poplawski wrote:
>> David Brownell wrote:
>> > On Monday 07 January 2008, Greg KH wrote:
>> >> Most of the non-driver core code should be converted to not use the
>> >> lock in the class at all.  They should use a local lock instead.
>> > 
>> > Or better yet, that yet-to-be-written class_for_each_instance()
>> > iterator ... :)
...
> I hope I'm wrong, but IMHO it should be safer not to mix such changes,
> so do the mutexes first or delay them until the end. Otherwise some
> false blaming seems almost inevitable.

I agree.  Sem2mutex conversion should not be mixed with API conversion,
even if one or both seem trivial.
-- 
Stefan Richter
-=====-==--- ---= --===
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/