linux-kernel - Re: [PATCH 2/3] pci: Remove users of pci_enable_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080107194225.GE13518@plap3.qlogic.org>
Date:	Mon, 7 Jan 2008 11:42:25 -0800
From:	Andrew Vasquez <andrew.vasquez@...gic.com>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	James Bottomley <james.bottomley@...eleye.com>
Cc:	Greg Kroah-Hartman <greg@...ah.com>,
	linux-pci@...ey.karlin.mff.cuni.cz, linux-kernel@...r.kernel.org,
	ink@...assic.park.msu.ru, Alan Cox <alan@...hat.com>,
	james.smart@...lex.com, linux-driver@...gic.com,
	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Subject: Re: [PATCH 2/3] pci: Remove users of pci_enable_device_bars()

On Thu, 20 Dec 2007, Benjamin Herrenschmidt wrote:

> This patch converts users of pci_enable_device_bars() to the new
> pci_enable_device_{io,mem} interface.
> 
> The new API fits nicely, except maybe for the QLA case where a bit of
> code re-organization might be a good idea but I prefer sticking to the
> simple patch as I don't have hardware to test on.

That's fine.  I take it these patches will be funneled via
gregkh/pci-2.6.git.  There's some qla2xxx updates which are queued for
post-2.6.24 consumption in jejb/scsi-misc-2.6.git which don't appear
to have any conflicts.

I do though have a series of patches which I'll hold off on submitting
to linux-scsi until these PCI changes are merged, as there's some
minor conflicts merging the three branches.  James B, will that be
fine?

The patches themselves appear to be working fine within several of our
test rings.  I hold off on some of the cleanup post-merge time...

Thanks,
Andrew Vasquez

> Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> ---
> 
>  drivers/ata/pata_cs5520.c       |    2 +-
>  drivers/i2c/busses/scx200_acb.c |    2 +-
>  drivers/ide/pci/cs5520.c        |   10 ++++++++--
>  drivers/ide/setup-pci.c         |    6 ++++--
>  drivers/scsi/lpfc/lpfc_init.c   |    3 +--
>  drivers/scsi/qla2xxx/qla_os.c   |   12 +++++++++---

Acked-by: Andrew Vasquez <andrew.vasquez@...gic.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/