linux-kernel - Re: [PATCH 00 of 10] x86: unify asm/pgtable.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080108231226.GA10744@elte.hu>
Date:	Wed, 9 Jan 2008 00:12:26 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, Andi Kleen <ak@...e.de>,
	Glauber de Oliveira Costa <glommer@...il.com>,
	Jan Beulich <jbeulich@...ell.com>
Subject: Re: [PATCH 00 of 10] x86: unify asm/pgtable.h


* Ingo Molnar <mingo@...e.hu> wrote:

> > Hi Ingo,
> > 
> > Here's a series which goes some way to tidying up pgtable.h.  It is 
> > not complete yet, but this lot compiles and works for me.
> > 
> > In many cases I've moved code around with no attempt at adjusting 
> > the formatting to acceptible style.  That can be done in a later 
> > patch, but it means that checkpatch is noisy with this lot.
> 
> thanks Jeremy, applied.

threw this into the random test setup: it found the attached config 
after a few iterations, which needed the fix below. (config builds and 
boots fine with this fix)

the problem was that set_pud() is used by 
include/asm-generic/pgtable-nopud.h, to build set_pgd():

#define set_pgd(pgdptr, pgdval)                 set_pud((pud_t *)(pgdptr), (pud_t) { pgdval })

it's truly a maze ... took me 10 straight minutes of staring at the code 
to figure out where the set_pud() came from :-/

anyway, your patchset is holding up pretty good so far in testing.

	Ingo

--------------------->
Subject: x86: unify-pgtable.h, fix
From: Ingo Molnar <mingo@...e.hu>

fix build error.

Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 include/asm-x86/pgtable.h |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: linux-x86.q/include/asm-x86/pgtable.h
===================================================================
--- linux-x86.q.orig/include/asm-x86/pgtable.h
+++ linux-x86.q/include/asm-x86/pgtable.h
@@ -190,10 +190,11 @@ static inline pte_t pte_modify(pte_t pte
 
 #ifndef __PAGETABLE_PUD_FOLDED
 #define set_pgd(pgdp, pgd)		native_set_pgd(pgdp, pgd)
-#define set_pud(pudp, pud)		native_set_pud(pudp, pud)
 #define pgd_clear(pgd)			native_pgd_clear(pgd)
 #endif
 
+#define set_pud(pudp, pud)		native_set_pud(pudp, pud)
+
 #ifndef __PAGETABLE_PMD_FOLDED
 #define pud_clear(pud)			native_pud_clear(pud)
 #endif


View attachment "config" of type "text/plain" (53388 bytes)