[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080108053725.GA8505@in.ibm.com>
Date: Tue, 8 Jan 2008 11:07:25 +0530
From: Ananth N Mavinakayanahalli <ananth@...ibm.com>
To: Harvey Harrison <harvey.harrison@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
LKML <linux-kernel@...r.kernel.org>,
Masami Hiramatsu <mhiramat@...hat.com>,
David Miller <davem@...emloft.net>, hskinnemoen@...el.com,
schwidefsky@...ibm.com, heiko.carstens@...ibm.com,
tony.luck@...el.com, paulus@...ba.org, Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCHv2] kprobes: Introduce is_kprobe_fault()
On Mon, Jan 07, 2008 at 12:24:46PM -0800, Harvey Harrison wrote:
> Use a central is_kprobe_fault() inline in kprobes.h to remove all
> of the arch-dependant, practically identical implementations in
> avr32, ia64, powerpc, s390, sparc64, and x86.
>
> avr32 was the only arch without the preempt_disable/enable pair
> in its notify_page_fault implementation.
>
> This uncovered a possible bug in the s390 version as that purely
> copied the x86 version unconditionally passing 14 as the trapnr
> rather than the error_code parameter.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
Tested on powerpc.
Tested-by: Ananth N Mavinakayanahalli <ananth@...ibm.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists