[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080109080800.GA32035@uranus.ravnborg.org>
Date: Wed, 9 Jan 2008 09:08:00 +0100
From: Sam Ravnborg <sam@...nborg.org>
To: Christoph Hellwig <hch@...radead.org>
Cc: Ingo Molnar <mingo@...e.hu>, Andi Kleen <andi@...stfloor.org>,
ananth@...ibm.com, akpm@...ux-foundation.org,
lkml <linux-kernel@...r.kernel.org>,
Jim Keniston <jkenisto@...ibm.com>, mhiramat@...hat.com,
davem@...emloft.net, hskinnemoen@...el.com
Subject: Re: [PATCH] Kprobes: Add kprobes smoke tests that run on boot
On Wed, Jan 09, 2008 at 08:00:03AM +0000, Christoph Hellwig wrote:
> On Tue, Jan 08, 2008 at 11:18:02PM +0100, Ingo Molnar wrote:
> >
> > * Andi Kleen <andi@...stfloor.org> wrote:
> >
> > > Ananth N Mavinakayanahalli <ananth@...ibm.com> writes:
> > > > kernel/kprobes.c | 2
> > > > kernel/test_kprobes.c | 216 ++++++++++++++++++++++++++++++++++++++++++++++++
> > >
> > > Can you put this somewhere else please? I know there are already some
> > > test files in kernel/* but imho they all belong into some other
> > > directory.
> >
> > agreed - lib/* would be the right place i think - we've got
> > lib/locking-selftest.c already.
>
> Actually the right place would be to have a separate toplevel directory
> I think, and a separate menu in the kernel config machinery. Thay way
> tests are in one place and easily spottable.
Seconded...
Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists