linux-kernel - Re: [-mm] new warning in ipc/msg.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080109151319.edff136c.akpm@linux-foundation.org>
Date:	Wed, 9 Jan 2008 15:13:19 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Pierre Peiffer <pierre.peiffer@...l.net>
Cc:	ricknu-0@...dent.ltu.se, nadia.derbey@...l.net,
	linux-kernel@...r.kernel.org
Subject: Re: [-mm] new warning in ipc/msg.c

On Wed, 09 Jan 2008 16:42:34 +0100
Pierre Peiffer <pierre.peiffer@...l.net> wrote:

> Hi,
> 
> This very small patch:
>     ipc-convert-handmade-min-to-min.patch
> introduces a new warning when compiling the -mm kernel:
> 
> .../linux-2.6.24-rc6-mm1/ipc/msg.c: In function `do_msgrcv':
> .../linux-2.6.24-rc6-mm1/ipc/msg.c:939: warning: comparison of distinct pointer
> types lacks a cast
> 
> I don't know if doing in include/linux/msg.h
> 
> struct msg_msg {
> 	struct list_head m_list;
> 	long  m_type;
> -	int m_ts;           /* message text size */
> +	size_t m_ts;           /* message text size */
> 	struct msg_msgseg* next;
> 	void *security;
> 	/* the actual message follows immediately */
> };
> 
> is acceptable ?
> 
> Otherwise, either a cast can be added or this patch can be dropped...
> 

Thanks.  I think I'll drop the original patch.  The mix of ints, size_t's,
etc in that code is pretty random and would be best addressed by somene
sitting down and working out from scratch what types we _should_ be using
in there and then making all the code use the right types in an organised
fashion.

Doing this in a piecemeal through-a-pinhole fashion won't work very well
and is a bit risky.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/