[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <4cc25cb20801112035x16c69a40rf3103a73b6cda107@mail.gmail.com>
Date: Sat, 12 Jan 2008 12:35:27 +0800
From: rmingming <mingming.nk@...il.com>
To: linux-kernel@...r.kernel.org
Subject: Is try_module_get buggy?
Hi,
I have a problem about the try_module_get function, I don't know if someone
removed the module just AFTER line 372, then what happens? Because in this
situation, the variable module will be incorrect, and module_is_live
function will lead to unpredicatable behaviour.
368 static inline int try_module_get(struct module *module)
369 {
370 int ret = 1;
371
372 if (module) {
373 unsigned int cpu = get_cpu();
374 if (likely(module_is_live(module)))
375 local_inc(&module->ref[cpu].count);
376 else
377 ret = 0;
378 put_cpu();
379 }
380 return ret;
381 }
Best wishes to all,
rmingming
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists