linux-kernel - Re: [PATCH 001/001] ipv4: enable use of 240/4 address space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080112.144729.67503025.yoshfuji@linux-ipv6.org>
Date:	Sat, 12 Jan 2008 14:47:29 +0900 (JST)
From:	YOSHIFUJI Hideaki / 吉藤英明 
	<yoshfuji@...ux-ipv6.org>
To:	vaf@...co.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	yoshfuji@...ux-ipv6.org, davem@...emloft.net
Subject: Re: [PATCH 001/001] ipv4: enable use of 240/4 address space

Hello.

In article <20080108011057.GA21168@...co.com> (at Mon, 7 Jan 2008 17:10:57 -0800), Vince Fuller <vaf@...co.com> says:

>  #define IN_MULTICAST_NET	0xF0000000
>  
> +#define IN_CLASSE(a)		((((long int) (a)) & 0xf0000000) == 0xf0000000)
> +#define	IN_CLASSE_NET		0xffffff00
> +#define	IN_CLASSE_NSHIFT	8
> +#define	IN_CLASSE_HOST		(0xffffffff & ~IN_CLASSE_NET)
> +
> +/* 
> + * these are no longer used
>  #define	IN_EXPERIMENTAL(a)	((((long int) (a)) & 0xf0000000) == 0xf0000000)
>  #define	IN_BADCLASS(a)		IN_EXPERIMENTAL((a))
> +*/

Please do not remove this, but have these instead:

#define IN_EXPERIMENTAL(a)	IN_CLASSE((a))
#define IN_BADCASS(a)		IN_CLASSE((a))

And, I think it is good to remove BADCLASS() (inside
#ifdef __KERNEL__ .. #endif) because we do not have its users
any longer, right?

Regards,

--yoshfuji
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/