[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080114232339.2c018647@paolo-desktop>
Date: Mon, 14 Jan 2008 23:23:39 +0100
From: Paolo Ciarrocchi <paolo.ciarrocchi@...il.com>
To: apw@...dowen.org, Linux Kernel <linux-kernel@...r.kernel.org>
Subject: [PATCH] checkpatch: add filename in the summary
Add a filename option (default to 0)
in order to get the following summary output:
./scripts/checkpatch.pl --filename --file ./arch/sparc/kernel/apc.c
...
...
...
./arch/sparc/kernel/apc.c --> total: 18 errors, 3 warnings, 186 lines checked
---
Andy,
I wonder why checkpatch doesn't show all the command line options.
At the moment, it only prints:
options: -q => quiet
--no-tree => run without a kernel tree
--terse => one line per report
--emacs => emacs compile window format
--file => check a source file
--strict => enable more subjective tests
--root => path to the kernel tree root
but I see a lot more options:
q|quiet
tree
signoff
patch
test-type
emacs
terse
file
subjective
strict
root=s
summary
mailback
scripts/checkpatch.pl | 10 +++++++++-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 579f50f..1762b73 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -24,6 +24,7 @@ my $file = 0;
my $check = 0;
my $summary = 1;
my $mailback = 0;
+my $patchfilename= 0;
my $root;
GetOptions(
'q|quiet+' => \$quiet,
@@ -39,6 +40,7 @@ GetOptions(
'root=s' => \$root,
'summary!' => \$summary,
'mailback!' => \$mailback,
+ 'filename' => \$patchfilename,
) or exit;
my $exit = 0;
@@ -1579,12 +1581,18 @@ sub process {
}
print report_dump();
- if ($summary) {
+ if ($summary == 1 && $patchfilename == 0) {
print "total: $cnt_error errors, $cnt_warn warnings, " .
(($check)? "$cnt_chk checks, " : "") .
"$cnt_lines lines checked\n";
print "\n" if ($quiet == 0);
}
+ if ($summary == 1 && $patchfilename == 1) {
+ print "$filename --> total: $cnt_error errors, $cnt_warn warnings, " .
+ (($check)? "$cnt_chk checks, " : "") .
+ "$cnt_lines lines checked\n";
+ print "\n" if ($quiet == 0);
+ }
if ($clean == 1 && $quiet == 0) {
print "Your patch has no obvious style problems and is ready for submission.\n"
--
1.5.4.rc3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists