linux-kernel - Re: rlim in proc/<pid>/status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080115194321.119D.KOSAKI.MOTOHIRO@jp.fujitsu.com>
Date:	Tue, 15 Jan 2008 19:47:22 +0900
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Clifford Wolf <clifford@...fford.at>
Cc:	kosaki.motohiro@...fujitsu.com, lkml <linux-kernel@...r.kernel.org>
Subject: Re: rlim in proc/<pid>/status

Hi

sound good for me.
a few question please.

> +	for (i=0; i<RLIM_NLIMITS; i++) {
> +		if (rlim_names[i])
> +			buffer += sprintf(buffer, "Rlim%s:\t", rlim_names[i]);
> +		else
> +			buffer += sprintf(buffer, "Rlim%d:\t", i);

this else is really necessary?

> +		if (rlim[i].rlim_cur != ~0)
> +			buffer += sprintf(buffer, "%lu\t", rlim[i].rlim_cur);
> +		else
> +			buffer += sprintf(buffer, "-\t");
> +		if (rlim[i].rlim_max != ~0)
> +			buffer += sprintf(buffer, "%lu\n", rlim[i].rlim_max);
> +		else
> +			buffer += sprintf(buffer, "-\n");

Why do you don't use RLIM_INFINITY?

- kosaki


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/