linux-kernel - [PATCH] kprobe: missing cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080114192155.2d6982ea@speedy>
Date:	Mon, 14 Jan 2008 19:21:55 -0800
From:	Stephen Hemminger <stephen.hemminger@...tta.com>
To:	prasanna@...ibm.com, ananth@...ibm.com,
	anil.s.keshavamurthy@...el.com
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] kprobe: missing cast

Fix warning from missing cast, maybe a result of the x86 merge?

Signed-off-by: Stephen Hemminger <stephen.hemminger@...tta.com>

  CC      arch/x86/kernel/kprobes_32.o
arch/x86/kernel/kprobes_32.c: In function ‘longjmp_break_handler’:
arch/x86/kernel/kprobes_32.c:729: warning: comparison of distinct pointer types lacks a cast

--- a/arch/x86/kernel/kprobes_32.c	2008-01-14 19:18:01.000000000 -0800
+++ b/arch/x86/kernel/kprobes_32.c	2008-01-14 19:18:08.000000000 -0800
@@ -726,7 +726,7 @@ int __kprobes longjmp_break_handler(stru
 	struct jprobe *jp = container_of(p, struct jprobe, kp);
 
 	if ((addr > (u8 *) jprobe_return) && (addr < (u8 *) jprobe_return_end)) {
-		if (&regs->esp != kcb->jprobe_saved_esp) {
+		if ((unsigned long *) &regs->esp != kcb->jprobe_saved_esp) {
 			struct pt_regs *saved_regs = &kcb->jprobe_saved_regs;
 			printk("current esp %p does not match saved esp %p\n",
 			       &regs->esp, kcb->jprobe_saved_esp);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/