linux-kernel - Re: [PATCH 4/4] libata: make libata use printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <478D71B6.7000400@gmail.com>
Date:	Wed, 16 Jan 2008 11:53:42 +0900
From:	Tejun Heo <htejun@...il.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
CC:	linux-kernel@...r.kernel.org, daniel.ritz-ml@...ssonline.ch,
	jeff@...zik.org, linux-ide@...r.kernel.org
Subject: Re: [PATCH 4/4] libata: make libata use printk_header() and mprintk

Randy Dunlap wrote:
>> -			ata_dev_printk(dev, KERN_WARNING,
>> -"Drive reports diagnostics failure. This may indicate a drive\n");
>> -			ata_dev_printk(dev, KERN_WARNING,
>> -"fault or invalid emulation. Contact drive vendor for information.\n");
>> -		}
> 
> Looks to me like several of these + lines have indent problems:
> following lines (i.e., not first line) of function call should be
> indented more than the first line:

Putting one more tab would put good part of those lines off the 80col
limit.  Hmmm... but I agree it looks ugly.  I'll add one or two spaces
there.

>> +		ata_dev_printk(dev, KERN_WARNING,
>> +		"Drive reports diagnostics failure. This may indicate a drive\n"
>> +		"fault or invalid emulation. Contact drive vendor for information.\n");

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/