linux-kernel - [PATCH] drivers edac i3000 document type promotion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <478d501a.Y76I0VJGkMZyz9aA%dougthompson@xmission.com>
Date:	Tue, 15 Jan 2008 17:30:18 -0700
From:	dougthompson@...ssion.com
To:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: [PATCH] drivers edac i3000 document type promotion

From: Jason Uhlenkott <juhlenko@...mai.com>

Applied to 2.6.24-rc6-mm1

By popular request, add a comment documenting the implicit type
promotion here.

Signed-off-by: Jason Uhlenkott <juhlenko@...mai.com>
Signed-off-by: Doug Thompson <dougthompson@...ssion.com?
---
 i3000_edac.c |    7 +++++++
 1 file changed, 7 insertions(+)

Index: linux/drivers/edac/i3000_edac.c
===================================================================
--- linux.orig/drivers/edac/i3000_edac.c	2008-01-14 15:16:11.137167678 -0800
+++ linux/drivers/edac/i3000_edac.c	2008-01-14 15:16:13.387855416 -0800
@@ -44,6 +44,13 @@
 				 */
 #define I3000_DEAP_GRAIN 		(1 << 7)
 
+/*
+ * Helper functions to decode the DEAP/EDEAP hardware registers.
+ *
+ * The type promotion here is deliberate; we're deriving an
+ * unsigned long pfn and offset from hardware regs which are u8/u32.
+ */
+
 static inline unsigned long deap_pfn(u8 edeap, u32 deap)
 {
 	deap >>= PAGE_SHIFT;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/