linux-kernel - [PATCH] fix hugepages leak due to pagetable page sharing.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <478F74A2.9090406@redhat.com>
Date:	Thu, 17 Jan 2008 10:30:42 -0500
From:	Larry Woodman <lwoodman@...hat.com>
To:	linux-kernel@...r.kernel.org
CC:	linux-mm@...ck.org
Subject: [PATCH] fix hugepages leak due to pagetable page sharing.

The shared page table code for hugetlb memory on x86 and x86_64
is causing a leak.  When a user of hugepages exits using this code
the system leaks some of the hugepages.

-------------------------------------------------------
Part of /proc/meminfo just before database startup:
HugePages_Total:  5500
HugePages_Free:   5500
HugePages_Rsvd:      0
Hugepagesize:     2048 kB

Just before shutdown:
HugePages_Total:  5500
HugePages_Free:   4475
HugePages_Rsvd:      0
Hugepagesize:     2048 kB

After shutdown:
HugePages_Total:  5500
HugePages_Free:   4988
HugePages_Rsvd:     
0 Hugepagesize:     2048 kB
----------------------------------------------------------

The problem occurs durring a fork, in copy_hugetlb_page_range(). It 
locates the dst_pte using
huge_pte_alloc().  Since huge_pte_alloc() calls huge_pmd_share() it will 
share the pmd page
if can, yet the main loop in copy_hugetlb_page_range() does a get_page() 
on every hugepage.
This is a violation of the shared hugepmd pagetable protocol and creates 
additional referenced
to the hugepages causing a leak when the unmap of the VMA occurs.   We 
can skip the entire
replication of the ptes when the hugepage pagetables are shared.
The attached patch skips copying the ptes and the get_page() calls if 
the hugetlbpage pagetable
is shared.

Signed-off-by: Larry Woodman <lwoodman@...hat.com>

View attachment "linux-shared.patch" of type "text/plain" (488 bytes)