linux-kernel - Re: [PATCH] [3/7] Use shorter addresses in i386 segfault printks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <478EC77E.8090103@zytor.com>
Date:	Wed, 16 Jan 2008 22:11:58 -0500
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Harvey Harrison <harvey.harrison@...il.com>
CC:	Andi Kleen <ak@...e.de>, mingo@...e.hu, tglx@...utronix.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [3/7] Use shorter addresses in i386 segfault printks

Harvey Harrison wrote:
> On Wed, 2008-01-16 at 23:27 +0100, Andi Kleen wrote:
>> Signed-off-by: Andi Kleen <ak@...e.de>
>>
>> ---
>>  arch/x86/mm/fault_32.c |    2 +-
> 
> Could use exactly the same in fault_64.c
> 
>>  #ifdef CONFIG_X86_32
>> -			"%s%s[%d]: segfault at %08lx ip %08lx sp %08lx error %lx\n",
>> +			"%s%s[%d]: segfault at %lx ip %08lx sp %08lx error %lx\n",
>>  #else
>>  			"%s%s[%d]: segfault at %lx ip %lx sp %lx error %lx\n",
>>  #endif
> 
> With the ongoing unification work, it would be nice if we could come
> up with a way to unify printks like this.  Anyone have any bright ideas
> on a format that will keep the current alignment on 32 and 64 bit with
> the same syntax, or will these tiny ifdefs keep sprouting?
> 

Casting to (void *) and using %p is probably your best bet.  That's what 
it really is anyway.

Note: in the kernel right now, %p doesn't have the leading 0x prefix, 
which it probably should...

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/