linux-kernel - Re: [PATCHv2] x86: Use v8086_mode helper, trivial unification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080118091208.GE24337@elte.hu>
Date:	Fri, 18 Jan 2008 10:12:08 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv2] x86: Use v8086_mode helper, trivial unification


* Harvey Harrison <harvey.harrison@...il.com> wrote:

> Use v8086_mode inline in fault_32.c, no functional change also ifdef 
> the section for 32-bit only and add to fault_64.c

> -	if (regs->flags & VM_MASK) {
> +	if (v8086_mode(regs)) {

> --- a/arch/x86/mm/fault_64.c
> +++ b/arch/x86/mm/fault_64.c
> @@ -551,6 +551,16 @@ good_area:
>  		tsk->maj_flt++;
>  	else
>  		tsk->min_flt++;
> +
> +	/*
> +	 * Did it hit the DOS screen memory VA from vm86 mode?
> +	 */
> +	if (v8086_mode(regs)) {
> +		unsigned long bit = (address - 0xA0000) >> PAGE_SHIFT;
> +		if (bit < 32)
> +			tsk->thread.screen_bitmap |= 1 << bit;
> +	}

hm, is there even vm86 mode in 64-bit? Anyway, gcc will eliminate it i 
guess. I've applied your patch.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/