linux-kernel - Re: [PATCHSET] printk: implement printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080118184457.GC20490@parisc-linux.org>
Date:	Fri, 18 Jan 2008 11:44:57 -0700
From:	Matthew Wilcox <matthew@....cx>
To:	Matt Mackall <mpm@...enic.com>
Cc:	Tejun Heo <htejun@...il.com>, linux-kernel@...r.kernel.org,
	daniel.ritz-ml@...ssonline.ch, randy.dunlap@...cle.com,
	jeff@...zik.org, linux-ide@...r.kernel.org
Subject: Re: [PATCHSET] printk: implement printk_header() and merging printk

On Fri, Jan 18, 2008 at 12:41:08PM -0600, Matt Mackall wrote:
> On Wed, 2008-01-16 at 10:00 +0900, Tejun Heo wrote:
> > And mprintk the following.
> > 
> >  code:
> >   DEFINE_MPRINTK(mp, 2 * 80);
> > 
> >   mprintk_set_header(&mp, KERN_INFO "ata%u.%2u: ", 1, 0);
> >   mprintk_push(&mp, "ATA %d", 7);
> >   mprintk_push(&mp, ", %u sectors\n", 1024);
> >   mprintk(&mp, "everything seems dandy\n");
> 
> I prefer Matthew Wilcox's stringbuf approach which does proper memory
> management and isn't specific to printk:
> 
> http://www.ussg.iu.edu/hypermail/linux/kernel/0710.3/0517.html

Do you have any strong feelings whether we should merge my stringbufs or
rusty's version?  I have no particular preference.

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/