linux-kernel - Re: [PATCHSET] printk: implement printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 18 Jan 2008 13:06:23 -0600
From:	Matt Mackall <mpm@...enic.com>
To:	Matthew Wilcox <matthew@....cx>
Cc:	Tejun Heo <htejun@...il.com>, linux-kernel@...r.kernel.org,
	daniel.ritz-ml@...ssonline.ch, randy.dunlap@...cle.com,
	jeff@...zik.org, linux-ide@...r.kernel.org
Subject: Re: [PATCHSET] printk: implement printk_header() and merging printk


On Fri, 2008-01-18 at 11:44 -0700, Matthew Wilcox wrote:
> On Fri, Jan 18, 2008 at 12:41:08PM -0600, Matt Mackall wrote:
> > On Wed, 2008-01-16 at 10:00 +0900, Tejun Heo wrote:
> > > And mprintk the following.
> > > 
> > >  code:
> > >   DEFINE_MPRINTK(mp, 2 * 80);
> > > 
> > >   mprintk_set_header(&mp, KERN_INFO "ata%u.%2u: ", 1, 0);
> > >   mprintk_push(&mp, "ATA %d", 7);
> > >   mprintk_push(&mp, ", %u sectors\n", 1024);
> > >   mprintk(&mp, "everything seems dandy\n");
> > 
> > I prefer Matthew Wilcox's stringbuf approach which does proper memory
> > management and isn't specific to printk:
> > 
> > http://www.ussg.iu.edu/hypermail/linux/kernel/0710.3/0517.html
> 
> Do you have any strong feelings whether we should merge my stringbufs or
> rusty's version?  I have no particular preference.

My vague recollection was that I preferred Rusty's. But it's been a
while.

-- 
Mathematics is the supreme nostalgia of our time.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/