linux-kernel - Re: [PATCHv2] x86: Use v8086_mode helper, trivial unification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4790F7BF.2070304@zytor.com>
Date:	Fri, 18 Jan 2008 14:02:23 -0500
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Harvey Harrison <harvey.harrison@...il.com>
CC:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv2] x86: Use v8086_mode helper, trivial unification

Harvey Harrison wrote:
> On Fri, 2008-01-18 at 16:00 +0100, Ingo Molnar wrote:
>>>> +	/*
>>>> +	 * Did it hit the DOS screen memory VA from vm86 mode?
>>>> +	 */
>>>> +	if (v8086_mode(regs)) {
>>>> +		unsigned long bit = (address - 0xA0000) >> PAGE_SHIFT;
>>>> +		if (bit < 32)
>>>> +			tsk->thread.screen_bitmap |= 1 << bit;
>>>> +	}
>> this does not build on 64-bit, because screen_bitmap is 32-bit only - so 
>> i had to pull the patch. I suspect a small #ifdef section would look 
>> better here?
>>
> 
> My original patch had the ifdef, you can grab that one.
> 

Me bad, I should have been less definite in my reply.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/