lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 18 Jan 2008 22:55:27 -0500 (EST)
From:	Steven Rostedt <>
To:	"Frank Ch. Eigler" <>
cc:	Mathieu Desnoyers <>,
	LKML <>, Ingo Molnar <>,
	Linus Torvalds <>,
	Andrew Morton <>,
	Peter Zijlstra <>,
	Christoph Hellwig <>,
	Gregory Haskins <>,
	Arnaldo Carvalho de Melo <>,
	Thomas Gleixner <>,
	Tim Bird <>,
	Sam Ravnborg <>,
	Steven Rostedt <>,
	Paul Mackerras <>,
	Daniel Walker <>
Subject: Re: [RFC PATCH 16/22 -v2] add get_monotonic_cycles

On Fri, 18 Jan 2008, Frank Ch. Eigler wrote:
> All this complexity is to be justified by keeping the raw prev/next
> pointers from being sent to a naive tracer?  It seems to me way out of
> proportion.

Damn, and I just blew away all my marker code for something like this ;-)

Actually, you just gave me a great idea that I think can help all of us.
OK, Mathieu may not be in total agreement, but I think this is the
ultimate compromise.

We have in sched.c the following marker:

 trace_mark(kernel_sched_scheduler, "prev %p next %p", prev, next);

Then Mathieu can add in some code somewhere (or a module, or something)

	ret = marker_probe_register("kernel_sched_scheduler",
				"prev %p next %p",
				pretty_print_sched_switch, NULL);

static void pretty_print_sched_switch(const struct marker *mdata,
				void *private_data,
				const char *format, ...)
	va_list ap;
	struct task_struct *prev;
	struct task_struct *next;

	va_start(ap, format);
	prev = va_arg(ap, typeof(prev));
	next = va_arg(ap, typeof(next));

		"prev_pid %d next_pid %d prev_state %ld",
		prev->pid, next->pid, prev->state);

Then LTTng on startup could arm the normal kernel_sched_switch code and
have the user see the nice one. All without adding any more goo or
overhead to the non tracing case, and keeping a few critical markers with
enough information to be useful to other tracers!


-- Steve

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists