linux-kernel - Re: [PATCH 1/7] Modules: Fold percpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4794BD0F.3050701@sgi.com>
Date:	Mon, 21 Jan 2008 07:41:03 -0800
From:	Mike Travis <travis@....com>
To:	David Miller <davem@...emloft.net>
CC:	akpm@...ux-foundation.org, ak@...e.de, mingo@...e.hu,
	clameter@....com, linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	rusty@...tcorp.com.au
Subject: Re: [PATCH 1/7] Modules: Fold percpu_modcopy into module.c

David Miller wrote:
> From: travis@....com
> Date: Fri, 18 Jan 2008 10:29:54 -0800
> 
>> percpu_modcopy() is defined multiple times in arch files. However, the only
>> user is module.c. Put a static definition into module.c and remove
>> the definitions from the arch files.
>>
>> Cc: Rusty Russell <rusty@...tcorp.com.au>
>> Cc: Andi Kleen <ak@...e.de>
>> Signed-off-by: Christoph Lameter <clameter@....com>
>> Signed-off-by: Mike Travis <travis@....com>
> 
> This doesn't build on sparc64.
> 
> The percpu_modcopy() removal from include/asm-sparc64/percpu.h
> leaked into patch #3 instead of being done here in patch #1
> where it belongs (so that this series is properly bisectable).
> 
> It also seems that the include/asm-x86/percpu_{32,64}.h defines
> aren't removed in this patch either.

Hi,

I think I have this fixed in the newest version.  Yes, it's been
a hat dance with some changes coming through the git-x86 patch
and others not.  I'll submit the new one shortly.

Thanks,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/