linux-kernel - Re: echo mem > /sys/power/state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080121223756.GA15875@elf.ucw.cz>
Date:	Mon, 21 Jan 2008 23:37:56 +0100
From:	Pavel Machek <pavel@....cz>
To:	Johannes Weiner <hannes@...urebad.de>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>, Zan Lynx <zlynx@....org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Len Brown <lenb@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: echo mem > /sys/power/state

Hi!

> > index f7dfff2..e5693d6 100644
> > --- a/kernel/power/Makefile
> > +++ b/kernel/power/Makefile
> > @@ -5,7 +5,7 @@ endif
> >  
> >  obj-y				:= main.o
> >  obj-$(CONFIG_PM_LEGACY)		+= pm.o
> > -obj-$(CONFIG_PM_SLEEP)		+= process.o console.o
> > +obj-$(CONFIG_PM_SLEEP)		+= process.o console.o sleepy.o
> 
> Why compiling it uncoditionally?  What would be wrong with

Its part of my world domination plan ;-).

> > +extern int set_alarm(int length);
> 
> Huh?

Set alarm belongs in drivers/rtc, moved now.

> > +	alarm = now+length;
> > +	rtc_time_to_tm(alarm, &alm.time);
> > +
> > +	retval = cmos_set_alarm(rtc, &alm);
> 
> cmos_set_alarm() takes a struct device * too.

Fixed.

Thanks,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/