[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <p731w88nc0p.fsf@crumb.suse.de>
Date: 23 Jan 2008 10:09:58 +0100
From: Andi Kleen <andi@...stfloor.org>
To: Arjan van de Ven <arjan@...radead.org>
Cc: mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: Re: [patch] x86: test case for the RODATA config option
Arjan van de Ven <arjan@...radead.org> writes:
> This patch adds a test module for the DEBUG_RODATA config
> option to make sure change_page_attr() did indeed make
> "const" data read only.
The only that this does that is not done pretty much equivalently
by pageattr-test.c (it just checks G instead of W) is testing the kernel
text mapping on 64bit. On 32bit it is fully redundant I believe.
Testing the kernel mapping might be a good idea, but I would
suggest adding it to pageattr-test.c
Yes I'm sure these basic facts will not stop it from being
applied anyways; just wanted to point it out for the benefit
of the list readers.
-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists