linux-kernel - Re: [patch] x86: test case for the RODATA config option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080122212944.34bbf2bd@laptopd505.fenrus.org>
Date:	Tue, 22 Jan 2008 21:29:44 -0800
From:	Arjan van de Ven <arjan@...radead.org>
To:	Nick Piggin <nickpiggin@...oo.com.au>
Cc:	mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: Re: [patch] x86: test case for the RODATA config option

On Wed, 23 Jan 2008 12:11:41 +1100
Nick Piggin <nickpiggin@...oo.com.au> wrote:

> >  #ifdef CONFIG_DEBUG_RODATA
> >
> > +const int rodata_test_data = 5;
> 
> I guess this should match the 32-bit case, and be zero instead of
> 5?

actually it should have been 5 for both (well any non-zero number)
> 
> Can you disallow building as a module, and put this in the test
> code? It could be run from the end of mark_rodata_ro()...

fair; I was developing it as a module (just easier) but yeah it makes more sense as part
of mark_rodata_ro(). I'll do that in the next rev


-- 
If you want to reach me at my work email, use arjan@...ux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/