linux-kernel - Re: [patch 01/26] mount options: add documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200801250024.m0P0OmXX011168@agora.fsl.cs.sunysb.edu>
Date:	Thu, 24 Jan 2008 19:24:48 -0500
From:	Erez Zadok <ezk@...sunysb.edu>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	akpm@...ux-foundation.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, Steve French <sfrench@...ibm.com>,
	Lachlan McIlroy <lachlan@....com>,
	"Josef 'Jeff' Sipek" <jsipek@...sunysb.edu>,
	Russell King <rmk@....linux.org.uk>,
	Roman Zippel <zippel@...ux-m68k.org>,
	David Howells <dhowells@...hat.com>,
	Ian Kent <raven@...maw.net>,
	"Sergey S. Kostyliov" <rathamahata@...4.ru>,
	Karsten Keil <kkeil@...e.de>, "H. Peter Anvin" <hpa@...or.com>,
	"Theodore Ts'o" <tytso@....edu>,
	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
	Jeff Dike <jdike@...toit.com>,
	Mikulas Patocka <mikulas@...ax.karlin.mff.cuni.cz>,
	William Irwin <wli@...omorphy.com>,
	Dave Kleikamp <shaggy@...tin.ibm.com>,
	Petr Vandrovec <vandrove@...cvut.cz>,
	Trond Myklebust <Trond.Myklebust@...app.com>,
	Jeff Mahoney <jeffm@...e.com>,
	Paul Mackerras <paulus@...ba.org>,
	Hugh Dickins <hugh@...itas.com>,
	Cyrill Gorcunov <gorcunov@...il.com>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [patch 01/26] mount options: add documentation 

In message <20080124193416.379218079@...redi.hu>, Miklos Szeredi writes:
> From: Miklos Szeredi <mszeredi@...e.cz>
> 
> This series addresses the problem of showing mount options in
> /proc/mounts.
> 
> Several filesystems which use mount options, have not implemented a
> .show_options superblock operation.  Several others have implemented
> this callback, but have not kept it fully up to date with the parsed
> options.
[...]

> The following filesystems still need fixing: CIFS, NFS, XFS, Unionfs,
> Reiser4.  For CIFS, NFS and XFS I wasn't able to understand how some
> of the options are used.  The last two are not yet in mainline, so I
> leave fixing those to their respective maintainers out of pure
> laziness.
> 
> Table displaying status of all in-kernel filesystems:
> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
> legend:
> 
>   none - fs has options, but doesn't define ->show_options()
>   some - fs defines ->show_options(), but some only options are shown
>   most - fs defines ->show_options(), and shows most of them
>   good - fs shows all options
>   noopt - fs does not have options
>   patch - a patch will be posted
[...]

> in -mm:
> 
> reiser4     some
> unionfs     none

Hi Miklos,

Where did you check for the existence of a ->show_options method for
unionfs?  Unionfs does implement ->show_options and supports all of the
mount/remount options.  See:

<http://git.kernel.org/?p=linux/kernel/git/ezk/unionfs.git;a=blob;f=fs/unionfs/super.c;h=986c980261a5b171147d66ac05bf08423e2fd6b6;hb=HEAD#l963>

The unionfs ->remount code supports branch-management options which can
add/del/change a branch, but we don't show those directly in ->show_options;
it makes more sense to show the final (and thus most current) branch
configuration.

Could you update your records please?

BTW, I should be able to use your save_mount_options().

Cheers,
Erez.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/