linux-kernel - DMI: create dmi_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080125201357.GA3234@infomag.infomag.iguana.be>
Date:	Fri, 25 Jan 2008 21:13:57 +0100
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Len Brown <len.brown@...el.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: DMI: create dmi_get_slot()

Hi Len,

I saw you added the dmi_get_slot function recently.
If I look in drivers/firmware/dmi_scan.c however I now see:

...

/**
 *	dmi_get_system_info - return DMI data value
 *	@field: data index (see enum dmi_field)
 *
 *	Returns one DMI data value, can be used to perform
 *	complex DMI data checks.
 */
const char *dmi_get_system_info(int field)
{
	return dmi_ident[field];
}
EXPORT_SYMBOL(dmi_get_system_info);

...

/**
 *	dmi_get_slot - return dmi_ident[slot]
 *	@slot:	index into dmi_ident[]
 */
char *dmi_get_slot(int slot)
{
	return(dmi_ident[slot]);
}

Didn't we duplicate code here?

Greetings,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/