linux-kernel - Re: DMI: create dmi_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200801251519.09818.lenb@kernel.org>
Date:	Fri, 25 Jan 2008 15:19:09 -0500
From:	Len Brown <lenb@...nel.org>
To:	Wim Van Sebroeck <wim@...ana.be>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: DMI: create dmi_get_slot()

On Friday 25 January 2008 15:13, Wim Van Sebroeck wrote:
> Hi Len,
> 
> I saw you added the dmi_get_slot function recently.
> If I look in drivers/firmware/dmi_scan.c however I now see:
> 
> ...
> 
> /**
>  *	dmi_get_system_info - return DMI data value
>  *	@field: data index (see enum dmi_field)
>  *
>  *	Returns one DMI data value, can be used to perform
>  *	complex DMI data checks.
>  */
> const char *dmi_get_system_info(int field)
> {
> 	return dmi_ident[field];
> }
> EXPORT_SYMBOL(dmi_get_system_info);
> 
> ...
> 
> /**
>  *	dmi_get_slot - return dmi_ident[slot]
>  *	@slot:	index into dmi_ident[]
>  */
> char *dmi_get_slot(int slot)
> {
> 	return(dmi_ident[slot]);
> }
> 
> Didn't we duplicate code here?

Yep, thanks for noticing, i'll delete the duplicate.

-Len
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/