linux-kernel - Re: [RFC] some page can't be migrated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0801241931500.32043@schroedinger.engr.sgi.com>
Date:	Thu, 24 Jan 2008 19:37:17 -0800 (PST)
From:	Christoph Lameter <clameter@....com>
To:	Shaohua Li <shaohua.li@...el.com>
cc:	lkml <linux-kernel@...r.kernel.org>,
	Nick Piggin <nickpiggin@...oo.com.au>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [RFC] some page can't be migrated

On Wed, 23 Jan 2008, Shaohua Li wrote:

> +
> +	/*
> +	 * See truncate_complete_page(). Anonymous page might have
> +	 * fs-private metadata, the page is truncated. Such page can't be
> +	 * migrated. Try to free metadata, so the page can be freed.
> +	 */

Well maybe you should change the comment to refer to an orphaned page. 
That is what Nick used. Also change the comment in truncate_complete_page. 
Anonymous page is confusing here because you check that it is *not* an 
anonymous page.

> +	if (!page->mapping && !PageAnon(page) && PagePrivate(page)) {
> +		try_to_release_page(page, GFP_KERNEL);
> +		goto unlock;
> +	}
> +


Could you move that into the corner case handling that follows?

So it would be something like

if (!page->mapping) {
	if (!PageAnon(page) && PagePrivate(page))
		try_to_relase_page(page, GFP_KERNEL);
	goto rcu_unlock;
}

?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/