linux-kernel - Re: [RFC] some page can't be migrated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1201233590.28282.13.camel@sli10-desk.sh.intel.com>
Date:	Fri, 25 Jan 2008 11:59:50 +0800
From:	Shaohua Li <shaohua.li@...el.com>
To:	Christoph Lameter <clameter@....com>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Nick Piggin <nickpiggin@...oo.com.au>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [RFC] some page can't be migrated


On Thu, 2008-01-24 at 19:37 -0800, Christoph Lameter wrote:
> On Wed, 23 Jan 2008, Shaohua Li wrote:
> 
> > +
> > +	/*
> > +	 * See truncate_complete_page(). Anonymous page might have
> > +	 * fs-private metadata, the page is truncated. Such page can't be
> > +	 * migrated. Try to free metadata, so the page can be freed.
> > +	 */
> 
> Well maybe you should change the comment to refer to an orphaned page. 
> That is what Nick used. Also change the comment in truncate_complete_page. 
> Anonymous page is confusing here because you check that it is *not* an 
> anonymous page.
> 
> > +	if (!page->mapping && !PageAnon(page) && PagePrivate(page)) {
> > +		try_to_release_page(page, GFP_KERNEL);
> > +		goto unlock;
> > +	}
> > +
> 
> 
> Could you move that into the corner case handling that follows?
> 
> So it would be something like
> 
> if (!page->mapping) {
> 	if (!PageAnon(page) && PagePrivate(page))
> 		try_to_relase_page(page, GFP_KERNEL);
> 	goto rcu_unlock;
> }
Ok, changed.

Orphaned page might have fs-private metadata, the page is truncated. As
the page hasn't mapping, page migration refuse to migrate the page. It
appears the page is only freed in page reclaim and if zone watermark is
low, the page is never freed, as a result migration always fail. I
thought we could free the metadata so such page can be freed in
migration and make migration more reliable.

Signed-off-by: Shaohua Li <shaohua.li@...el.com>

diff --git a/mm/migrate.c b/mm/migrate.c
index 6a207e8..e82acc9 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -652,8 +652,16 @@ static int unmap_and_move(new_page_t get_new_page, unsigned long private,
 	 * Calling try_to_unmap() against a page->mapping==NULL page is
 	 * BUG. So handle it here.
 	 */
-	if (!page->mapping)
+	if (!page->mapping) {
+		/*
+		 * See truncate_complete_page(). Orphaned page might have
+		 * fs-private metadata, the page is truncated. Such page can't
+		 * be migrated. Try to free metadata, so the page can be freed.
+		 */
+		if (!PageAnon(page) && PagePrivate(page))
+			try_to_release_page(page, GFP_KERNEL);
 		goto rcu_unlock;
+	}
 	/* Establish migration ptes or remove ptes */
 	try_to_unmap(page, 1);
 
diff --git a/mm/truncate.c b/mm/truncate.c
index cadc156..62fd8cd 100644
--- a/mm/truncate.c
+++ b/mm/truncate.c
@@ -84,7 +84,7 @@ EXPORT_SYMBOL(cancel_dirty_page);
 
 /*
  * If truncate cannot remove the fs-private metadata from the page, the page
- * becomes anonymous.  It will be left on the LRU and may even be mapped into
+ * becomes orphaned.  It will be left on the LRU and may even be mapped into
  * user pagetables if we're racing with filemap_fault().
  *
  * We need to bale out if page->mapping is no longer equal to the original


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/