linux-kernel - Re: [PATCH] [MEMSTICK] Updates for the memstick driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 26 Jan 2008 22:01:47 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Alex Dubov <oakad@...oo.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [MEMSTICK] Updates for the memstick driver

> On Thu, 24 Jan 2008 23:58:52 -0800 (PST) Alex Dubov <oakad@...oo.com> wrote:
> * Mark shared inline functions as static
> 
> * Use member-at-a-time assignment for protocol structures
> 
> * Comments for publicly exported functions
> 
> * Use end_queued_request to end unhandled block layer requests
> 
> * Use sysfs attribute group to export MSPro attributes
> 
> * Fix includes
> 
> * Use scnprintf instead of snprintf where string length matters
> 
> * Remove spurious get_device/put_device in probe method
> 

Please sign off your patches.

Please don't send wordwrapped patches.

Please put the subsystem identifier "memstick" outside [], for reasons
described in http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt

Your patch contained a fix which I already merged into -mm, which suggests
that you haven't been testing the code in 2.6.24-rc8-mm1.  Please do test
-mm when you have patches in there, so that we know that we'll be merging
things which work.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/