linux-kernel - Re: [PATCH] defer printks in irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080126220151.784893b1.akpm@linux-foundation.org>
Date:	Sat, 26 Jan 2008 22:01:51 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Tim Bird <tim.bird@...sony.com>
Cc:	a.p.zijlstra@...llo.nl, rostedt@...dmis.org, dwalker@...sta.com,
	linux-kernel@...r.kernel.org, mingo@...e.hu,
	torvalds@...ux-foundation.org, hch@...radead.org,
	mathieu.desnoyers@...ymtl.ca, ghaskins@...ell.com,
	acme@...stprotocols.net, tglx@...utronix.de, sam@...nborg.org,
	fche@...hat.com, jan.kiszka@...mens.com, johnstul@...ibm.com,
	arjan@...radead.org, srostedt@...hat.com
Subject: Re: [PATCH] defer printks in irqs

> On Thu, 24 Jan 2008 15:23:03 -0800 Tim Bird <tim.bird@...sony.com> wrote:
> Peter Zijlstra wrote:
> > I suspect these features reduce the chance a crash messages makes it out
> > onto the console, but fail to spot any of the copious text mention this
> > critical issue.
> 
> Anything not in interrupts would not be deferred.
> The following code is meant to avoid deferring in oops as well.
> I'm not sure if that covers all crash cases or not.
> If you know of other cases, and ways to detect them, please advise.
> 

Yes, using oops_in_progress seems an appropriate fix for that.

I assume that another downside is that printk-from-interrupt will now get
jumbled up with an interrupted pritk-from-non-interrupt.

Please use checkpatch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/