lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 30 Jan 2008 01:12:45 -0500
From:	Pavel Roskin <proski@....org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Jon Masters <jonathan@...masters.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	linux-kernel@...r.kernel.org,
	Rusty Russell <rusty@...tcorp.com.au>,
	Giridhar Pemmasani <pgiri@...oo.com>
Subject: Re: ndiswrapper and GPL-only symbols redux

Quoting Andi Kleen <andi@...stfloor.org>:

> Pavel Roskin <proski@....org> writes:
>>   */
>> @@ -162,6 +163,7 @@ const char *print_tainted(void)
>>  	if (tainted) {
>>  		snprintf(buf, sizeof(buf), "Tainted: %c%c%c%c%c%c%c%c",
>>  			tainted & TAINT_PROPRIETARY_MODULE ? 'P' : 'G',
>> +			tainted & TAINT_BLOB_WRAPPER ? 'W' : ' ',
>
>
> Are you sure you don't need to add a new '%c' to the format string too?
> I think gcc should have warned.

You are right!  Thanks.

-- 
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ