linux-kernel - Re: [PATCH 2/2] Char: applicom, use pci_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080130151022.c52ad664.akpm@linux-foundation.org>
Date:	Wed, 30 Jan 2008 15:10:22 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	linux-kernel@...r.kernel.org, dwmw2@...radead.org,
	jirislaby@...il.com, xiyou.wangcong@...il.com
Subject: Re: [PATCH 2/2] Char: applicom, use pci_match_id

On Wed, 30 Jan 2008 12:13:15 +0100
Jiri Slaby <jirislaby@...il.com> wrote:

> +		if (!pci_match_id(applicom_pci_tbl, dev));
>  			continue;


The patch was carelessly prepared, was not runtine-tested and was not
passed through checkpatch, which detects this error.  Please fix these
things, permanently.

It's hard to overemphasise how out-of-balance the economics are here.  You
saved maybe thirty person-seconds by skipping the review and checkpatch
steps.  But the cost (if this bug had gone into mainline) would be many
many thousands times higher than this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/