linux-kernel - Re: [PATCH 2/2] Char: applicom, use pci_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 31 Jan 2008 10:26:17 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	linux-kernel@...r.kernel.org, dwmw2@...radead.org,
	xiyou.wangcong@...il.com
Subject: Re: [PATCH 2/2] Char: applicom, use pci_match_id

On 01/31/2008 12:10 AM, Andrew Morton wrote:
> On Wed, 30 Jan 2008 12:13:15 +0100
> Jiri Slaby <jirislaby@...il.com> wrote:
> 
>> +		if (!pci_match_id(applicom_pci_tbl, dev));
>>  			continue;
> 
> 
> The patch was carelessly prepared, was not runtine-tested and was not
> passed through checkpatch, which detects this error.  Please fix these
> things, permanently.

Yes, you're right, I definitely need to change my workflow, this needn't happen.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/