linux-kernel - Re: [PATCH] lguest: fix mis-merge against hpa's TSS renaming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080131092341.GA10841@elte.hu>
Date:	Thu, 31 Jan 2008 10:23:41 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	"H. Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org,
	lguest <lguest@...abs.org>
Subject: Re: [PATCH] lguest: fix mis-merge against hpa's TSS renaming


* Rusty Russell <rusty@...tcorp.com.au> wrote:

> --- a/drivers/lguest/x86/core.c	Thu Jan 31 14:50:43 2008 +1100
> +++ b/drivers/lguest/x86/core.c	Thu Jan 31 17:58:44 2008 +1100
> @@ -94,7 +94,7 @@ static void copy_in_guest_info(struct lg
>  	/* Set up the two "TSS" members which tell the CPU what stack to use
>  	 * for traps which do directly into the Guest (ie. traps at privilege
>  	 * level 1). */
> -	pages->state.guest_tss.esp1 = cpu->esp1;
> +	pages->state.guest_tss.sp1 = cpu->esp1;

btw., could you perhaps (later on) rename it to ->sp1, so that all the 
register namings are consistent in the x86 architecture? Might be handy 
for lguest-64 as well :-)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/