linux-kernel - Re: [PATCH] lguest: fix mis-merge against hpa's TSS renaming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080131093307.GA11180@elte.hu>
Date:	Thu, 31 Jan 2008 10:33:07 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	"H. Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org,
	lguest <lguest@...abs.org>
Subject: Re: [PATCH] lguest: fix mis-merge against hpa's TSS renaming


> * Rusty Russell <rusty@...tcorp.com.au> wrote:
> 
> > --- a/drivers/lguest/x86/core.c	Thu Jan 31 14:50:43 2008 +1100
> > +++ b/drivers/lguest/x86/core.c	Thu Jan 31 17:58:44 2008 +1100
> > @@ -94,7 +94,7 @@ static void copy_in_guest_info(struct lg
> >  	/* Set up the two "TSS" members which tell the CPU what stack to use
> >  	 * for traps which do directly into the Guest (ie. traps at privilege
> >  	 * level 1). */
> > -	pages->state.guest_tss.esp1 = cpu->esp1;
> > +	pages->state.guest_tss.sp1 = cpu->esp1;

arch/x86 testing found the build bug above, and with the fix applied it 
found a link bug s well:

 drivers/built-in.o: In function `start_switcher_text':
 : undefined reference to `LGUEST_PAGES_host_gdt_desc'
 drivers/built-in.o: In function `return_to_host':
 drivers/lguest/x86/switcher_32.S:(.text+0x30821b): undefined reference to `LGUEST_PAGES_regs_trapnum'

(etc.) Config attached.

	Ingo

View attachment "config" of type "text/plain" (48357 bytes)