lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <p73bq746lml.fsf@bingen.suse.de>
Date:	Wed, 30 Jan 2008 04:24:50 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Pavel Roskin <proski@....org>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>, linux-kernel@...r.kernel.org,
	Jon Masters <jonathan@...masters.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Giridhar Pemmasani <pgiri@...oo.com>
Subject: Re: ndiswrapper and GPL-only symbols redux

Pavel Roskin <proski@....org> writes:
>
> static inline void add_taint_module(struct module *mod, unsigned flag)
> {
>         add_taint(flag);
>         mod->taints |= flag;
> }
>
> The module taint is set before the symbols are resolved.  Therefore, the
> GPL-only symbols won't be resolved.

I think using a separate taint flag that does not disable GPL symbols
for the ndiswrapper case would be a fair solution. After all the main
motivation for tainting ndiswrapper is to make it visible in oopses, but not 
prevent it from loading in the first place.

How about you submit an incremental patch to do that?

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ