linux-kernel - Re: [PATCH 5/5] x86: EFI memory mapping changes according to changes to ioremap and c_p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <851fc09e0801310530p5f5839aat141ae9fcb6713b25@mail.gmail.com>
Date:	Thu, 31 Jan 2008 21:30:19 +0800
From:	"huang ying" <huang.ying.caritas@...il.com>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	"Huang, Ying" <ying.huang@...el.com>,
	"Ingo Molnar" <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>,
	"Thomas Gleixner" <tglx@...utronix.de>, "Andi Kleen" <ak@...e.de>,
	linux-kernel@...r.kernel.org,
	"Arjan van de Ven" <arjan@...radead.org>
Subject: Re: [PATCH 5/5] x86: EFI memory mapping changes according to changes to ioremap and c_p_a

Jan 31, 2008 8:18 PM, Ingo Molnar <mingo@...e.hu> wrote:
>
> * Huang, Ying <ying.huang@...el.com> wrote:
>
> > +                     /* Assume pages are mapped as WB */
> > +                     if (mode == IOR_MODE_UNCACHED)
> > +                             set_memory_uc(md->virt_addr, md->num_pages);
> > +                     /* Assume pages are mapped as unexecutable */
> > +                     if ((__supported_pte_mask & _PAGE_NX) &&
> > +                         xmode == IOR_XMODE_EXEC)
> > +                             set_memory_x(md->virt_addr, md->num_pages);
>
> hm, why is the check for __supported_pte_mask needed? That is already
> listened to in set_memory_x(). [if not then it's an ioremap bug that we
> want to fix.]

OK, I will check it.

> > -static int ioremap_change_attr(unsigned long paddr, unsigned long size,
> > -                            enum ioremap_mode mode,
> > -                            enum ioremap_xmode xmode)
> > +int ioremap_change_attr(unsigned long paddr, unsigned long size,
> > +                     enum ioremap_mode mode,
> > +                     enum ioremap_xmode xmode)
>
> hm, there should be no need to use this raw API.

Oh, you are right. __efi_ioremap() is only used when there is no
identity map. So ioremap_change_attr() need not to be called in
__efi_ioremap().

Best Regards,
Huang Ying
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/