linux-kernel - Re: [PATCH] x86_64: remove unneeded round

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 31 Jan 2008 23:53:25 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <Yinghai.Lu@....COM>
Cc:	Andi Kleen <ak@...e.de>, Christoph Lameter <clameter@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] x86_64: remove unneeded round_up


* Yinghai Lu <Yinghai.Lu@....COM> wrote:

> -	if (mem != -1L) {
> -		mem = round_up(mem, align);
> +	if (mem != -1L)
>  		return __va(mem);
> -	}

thanks, applied.

It even reduces the size of the kernel a tiny bit:

   text    data     bss     dec     hex filename
   2963    4149    4352   11464    2cc8 numa_64.o.before
   2949    4149    4352   11450    2cba numa_64.o.after

and it's always a good sign to kernel quality when patches (that change 
functionality) have that effect :)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/