linux-kernel - Re: [PATCH 7/7] fix lines over 80 characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4d8e3fd30801311454r3740fa85x629b22c8fbb758ef@mail.gmail.com>
Date:	Fri, 1 Feb 2008 02:24:16 +0330
From:	"Paolo Ciarrocchi" <paolo.ciarrocchi@...il.com>
To:	"Stefan Richter" <stefanr@...6.in-berlin.de>
Cc:	"Ingo Molnar" <mingo@...e.hu>,
	"Linux Kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 7/7] fix lines over 80 characters

On 1/29/08, Stefan Richter <stefanr@...6.in-berlin.de> wrote:
> Paolo Ciarrocchi wrote:
> > --- a/arch/x86/math-emu/errors.c
> > +++ b/arch/x86/math-emu/errors.c
> > @@ -75,7 +75,8 @@ void FPU_printall(void)
> >  	  FPU_get_user(FPU_modrm, 1 + (u_char __user *) address);
> >
> >  	  if (FPU_modrm >= 0300)
> > -	    printk(KERN_ERR " %02x (%02x+%d)\n", FPU_modrm, FPU_modrm & 0xf8,
> FPU_modrm & 7);
> > +	    printk(KERN_ERR " %02x (%02x+%d)\n", FPU_modrm, FPU_modrm & 0xf8,
> > +		FPU_modrm & 7);
> >  	  else
> >  	    printk(KERN_ERR " /%d, mod=%d rm=%d\n",
> >  		   (FPU_modrm >> 3) & 7, (FPU_modrm >> 6) & 3, FPU_modrm & 7);
> > @@ -309,7 +310,8 @@ asmlinkage void FPU_exception(int n)
> >  	printk(KERN_ERR "FPU emulator: Unknown Exception: 0x%04x!\n", n);
> >
> >        if (n == EX_INTERNAL) {
> > -	  printk(KERN_ERR "FPU emulator: Internal error type 0x%04x\n",
> int_type);
> > +	  printk(KERN_ERR "FPU emulator: Internal error type 0x%04x\n",
> > +		int_type);
> >  	  FPU_printall();
> >  	}
> >  #ifdef PRINT_MESSAGES
>
>
> The "fix" is still not conforming to CodingStyle.
>
> Besides, why don't you leave these lines as they are?  There is no
> important information hidden behind the 80th column in the existing code.


Yes, you are right.
Ingo, patch 7 deserves to be deleted.

Ciao,
-- 
Paolo
http://paolo.ciarrocchi.googlepages.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/