linux-kernel - Re: [PATCH] x86: cleanup - eliminate numbers in LDT allocation code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080201172729.GC6730@cvg>
Date:	Fri, 1 Feb 2008 20:27:29 +0300
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Thomas Gleixner <tglx@...utronix.de>, Andi Kleen <ak@...e.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: cleanup - eliminate numbers in LDT allocation code

[Ingo Molnar - Fri, Feb 01, 2008 at 06:18:26PM +0100]
| 
| * Cyrill Gorcunov <gorcunov@...il.com> wrote:
| 
| > This patch eliminates numbers in LDT allocation code trying to make it 
| > clear to understand from where these numbers are go
| 
| thanks, applied.
| 
| > I hope nobody shoot me ;)
| 
| nope, magic constants are bad in general.
| 
| 	Ingo
|

Thanks Ingo, and really thanks to Andi for his
explanation on this case.

		- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/