linux-kernel - Re: Commit f06e4ec breaks vmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080204115144.GA17850@elte.hu>
Date:	Mon, 4 Feb 2008 12:51:44 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Jan Engelhardt <jengelh@...putergmbh.de>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	petr@...drovec.name
Subject: Re: Commit f06e4ec breaks vmware


* Jan Engelhardt <jengelh@...putergmbh.de> wrote:

> sad to say, but f06e4ec... breaks booting the kernel in vmware 
> (bisected). Booting just stops after
> 
> 	Checking for 'hlt' instruction...
> 
> commit f06e4ec1c15691b0cfd2397ae32214fa36c90d71
> Author: Ingo Molnar <mingo@...e.hu>
> Date:   Wed Jan 30 13:32:39 2008 +0100
> 
>     x86: read_tsc sync
>     
>     make native_read_tsc() always non-speculative.

could you send us the /proc/cpuinfo data of the guest CPU?

if latest -git still fails, does the patch below solve the problem?

	Ingo

---
 include/asm-x86/system.h |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: linux-x86.q/include/asm-x86/system.h
===================================================================
--- linux-x86.q.orig/include/asm-x86/system.h
+++ linux-x86.q/include/asm-x86/system.h
@@ -407,8 +407,7 @@ void default_idle(void);
  */
 static inline void rdtsc_barrier(void)
 {
-	alternative(ASM_NOP3, "mfence", X86_FEATURE_MFENCE_RDTSC);
-	alternative(ASM_NOP3, "lfence", X86_FEATURE_LFENCE_RDTSC);
+	smp_mb();
 }
 
 #endif
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/