linux-kernel - Re: 2.6.24-git4+ regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080204120131.GA20962@elte.hu>
Date:	Mon, 4 Feb 2008 13:01:32 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Lukas Hejtmanek <xhejtman@....muni.cz>
Cc:	mingo@...hat.com, linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: 2.6.24-git4+ regression


* Lukas Hejtmanek <xhejtman@....muni.cz> wrote:

> but in such a case, kernel 2.6.24-git13 does oops at startup in 
> sched_slice.

could you tell me more about this oops? You booted unmodified, latest 
-git and it oopsed in sched_slice()? The patch below should work around 
any oopses in sched_slice(). [but this is really a 'must not happen' 
scenario - so a just-for-testing patch]

	Ingo

Index: linux-x86.q/kernel/sched_fair.c
===================================================================
--- linux-x86.q.orig/kernel/sched_fair.c
+++ linux-x86.q/kernel/sched_fair.c
@@ -268,7 +268,8 @@ static u64 sched_slice(struct cfs_rq *cf
 	u64 slice = __sched_period(cfs_rq->nr_running);
 
 	slice *= se->load.weight;
-	do_div(slice, cfs_rq->load.weight);
+	if (cfs_rq->load.weight)
+		do_div(slice, cfs_rq->load.weight);
 
 	return slice;
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/