linux-kernel - Re: tg3 broken after "PCI: Fix bus resource assignment on 32 bits with 64b resources"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080205091758.GB26618@localhost.sw.ru>
Date:	Tue, 5 Feb 2008 12:17:58 +0300
From:	Alexey Dobriyan <adobriyan@...ru>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: tg3 broken after "PCI: Fix bus resource assignment on 32 bits with 64b resources"

On Tue, Feb 05, 2008 at 08:54:33AM +1100, Benjamin Herrenschmidt wrote:
> 
> On Mon, 2008-02-04 at 18:12 +0300, Alexey Dobriyan wrote:
> > Commit c40a22e0ce5eb400f27449e59e43d021bee58b8d aka
> > "PCI: Fix bus resource assignment on 32 bits with 64b resources"
> > renders one tg3-equipped box networkless here.
> > 
> > 	tg3.c:v3.87 (December 20, 2007)
> > 	tg3: (0000:02:05.0) phy probe failed, err -19
> > 	tg3: Problem fetching invariants of chip, aborting.
> > 	tg3: (0000:02:05.1) phy probe failed, err -19
> > 	tg3: Problem fetching invariants of chip, aborting.
> > 
> > It's 32-bit CONFIG_RESOURCES_64BIT=y box.
> > 
> > Not sure what you need this, but below is some lspci -vvvxxx output:
> 
> Interesting. It looks like the BAR of the tg3 has a spurrious 0x100000000
> bit set to it. Can you send me a full dmesg, if possible enabling DEBUG
> in the pci code (there's some places to turn DEBUG on in drivers/pci/*)

OK, attached data collected on 2.6.24-9ef9dc69d4167276c04590d67ee55de8380bc1ad
with CONFIG_PCI_DEBUG=y with and without your patch:
(-000 means vanilla, -001 means with reverted patch)

-rw-r--r-- 1 ad ad 25261 2008-02-05 12:08 tg3-000.dmesg
-rw-r--r-- 1 ad ad  1112 2008-02-05 12:08 tg3-000.iomem
-rw-r--r-- 1 ad ad 37785 2008-02-05 12:08 tg3-000.lspci
-rw-r--r-- 1 ad ad 25495 2008-02-05 12:08 tg3-001.dmesg
-rw-r--r-- 1 ad ad  1172 2008-02-05 12:08 tg3-001.iomem
-rw-r--r-- 1 ad ad 37933 2008-02-05 12:08 tg3-001.lspci

dmesg is full of such chunks:
-  got res [180000000:180ffffff] bus [180000000:180ffffff] flags 200 for BAR 0 of 0000:03:04.0
+  got res [180000000:180ffffff] bus [80000000:80ffffff] flags 200 for BAR 0 of 0000:03:04.0

which is definitely not difference in formatting.

View attachment "broken-tg3.tar.bz2" of type "text/plain" (27121 bytes)