linux-kernel - Re: [PATCH] at91_mci: use generic GPIO calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200802050207.44721.david-b@pacbell.net>
Date:	Tue, 5 Feb 2008 02:07:44 -0800
From:	David Brownell <david-b@...bell.net>
To:	Marc Pignat <marc.pignat@...s.ch>
Cc:	linux-arm-kernel@...ts.arm.linux.org.uk,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Pierre Ossman <drzeus-mmc@...eus.cx>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	Andrew Victor <linux@...im.org.za>
Subject: Re: [PATCH] at91_mci:  use generic GPIO calls

On Tuesday 05 February 2008, Marc Pignat wrote:
> Hi all!
> 
> >  /*
> > @@ -946,9 +986,10 @@ static int __exit at91_mci_remove(struct
> >  	host = mmc_priv(mmc);
> >  
> >  	if (host->board->det_pin) {
> > +		if (device_can_wakeup(&pdev->dev))
> > +			free_irq(gpio_to_irq(host->board->det_pin), host);
>
> Seems strange to use device_can_wakeup(&pdev->dev) as
> have_we_requested_this_irq(gpio_to_irq(host->board->det_pin))... but seems to
> work.

Yeah ... it only works because the device_init_wakeup() is
done in the driver (sigh) instead of the device setup code.
Now that's only done if that IRQ was correctly requested,
so that bit does double duty.

Previously the driver always freeed that IRQ, even if it
hadn't actually managed to request it ... ;)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/